What's the proper way to make changes to the website?

Good questions!

The GitHub issues are only for quick fixes that need no discussion, for example dns0.eu has been discontinued · Issue #3152 · privacyguides/privacyguides.org · GitHub is obvious because everyone can clearly see dns0.eu was indeed discontinued, and we made a quick PR to merge it within 6 hours.

Otherwise, we want everything to first be discussed in:

We wait for those to be marked as approved before a team member makes a Pull Request for them.

Usually other people do not write Pull Requests, although you are certainly welcome to, and it does happen from non-team members occasionally. I typically wouldn’t recommend it though, because we have a specific writing style, and especially if you’re making a Pull Request about something that hasn’t been pre-approved then it can take a long time.

We do get a good number of Pull Requests about things which have never been discussed in the community before, and they typically end up closed or they can take months or longer to merge, and then those contributors feel discouraged about the whole process, which is really unfortunate. So that is why I usually would prefer people make suggestions here on the forum first, and then a team member will write a Pull Request when the time is right.

Yes. The quickest PRs to merge are ones that close GitHub Issues or ones that complete an approved suggestion.

Usually here on the forum. If you click the new issue button on GitHub it will tell you exactly when and when not to post to GitHub though.

You can absolutely do that without prior discussion if the meaning of the text does not change.

Something I will note though: Every time we change a sentence, it means that sentence has to be re-translated by our volunteer translators. For that reason I typically don’t like Pull Requests that make minor grammar changes unless they are particularly egregious problems.

Typically we prioritize approving them based on the number of votes they have, but they can be approved and completed in any order, and we do read all of them.

Depends on the topic.

4 Likes