My 2 cents.
My first serious notes where OneNote, but they are cumbersome and when you have a chance to explore the world of note apps you can truly see how limited they are. Then I went to Evernote, but too late fund out about their privacy policy,… which is terrible and now I have to migrate about 5 years of notes. And I can note simply export, must do note by note. In the meantime, they will parade trough my private stuff.
So, I switched to Notesnook, which is OK, but has glimpses and cost me some notes when updates, sync etc. are not there yet – they need some time to develop it properly.
In the meantime, I have found Obsidian which was on the first rune too much for me, but now I do almost everything in it. I used cryptomator and OneDrive to sync it. I use some of the plugins that truly are extreme time saver (e. g. plugin that changes the url link into name of page automatically). The ability to tweek every part of notes and connect it is truly an option that helps to build a knowledge base. For privacy I trust reddit, this forum and other that thy when thru the code and see that is OK, the same for plugins.